Skip to content
This repository has been archived by the owner on Oct 2, 2020. It is now read-only.

Adding trim_step source file to remove duplicate lines from STEP files #83

Closed
wants to merge 1 commit into from

Conversation

sethhillbrand
Copy link

This source file will take a STEP file and in-place replace it with a shrunk version that removes the duplicate lines and replaces them with a reference to the original line.

@CLAassistant
Copy link

CLAassistant commented Jan 20, 2018

CLA assistant check
All committers have signed the CLA.

@sethhillbrand sethhillbrand changed the title Adding trip_step source file to remove duplicate lines from STEP files Adding trim_step source file to remove duplicate lines from STEP files Jan 20, 2018
@sethhillbrand
Copy link
Author

Re-pushed the commit with a bug fix to deal with lines that have more than one '='

@antoniovazquezblanco
Copy link
Collaborator

@sethhillbrand I am trying to do some cleanup of KiCad GH issues and PRs. I have seen the thread in KiCad/kicad-packages3D#223. It seems changes will not be merged. Should we close this PR also or is this work check pending?

BTW I am interested in this size srinking but seems a little bit unstable. Have you tryed to contribute to FreeCAD or OCC given your knowledge of the STEP file format? It would be nice to see this improvements without having to bypass file generators or without having to process STEP files twice. :)

@sethhillbrand
Copy link
Author

@antoniovazquezblanco The code as is has no known issues. That said, it is only tested against the models in the KiCad repository.

@Shackmeister
Copy link
Collaborator

Shackmeister commented Jul 19, 2018

Hi @sethhillbrand

Could you possibly create an issue over at the OCC Developer page, describing this approach? http://git.dev.opencascade.org/gitweb/?p=occt.git
Or perhaps the forum
https://www.opencascade.com/forums
If there should be any issues with it, I believe these guys would be able to point it out, if not I would love to see it in the OCC kernel! If we could get to that point, we could respin all the generator scripts to shrink the entire repo. Also this would keep the size small for a PCB exported from kicad or freecad

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants